ARKODE_MRI interface #3013
ARKODE_MRI interface #3013
Conversation
| #include "bout/build_config.hxx" | ||
| #include "bout/solver.hxx" | ||
|
|
||
| #if not BOUT_HAS_ARKODE |
There was a problem hiding this comment.
Would it be possible to have a preprocessor-based test for the ARKODE version? I ask because BOUT++ can generally be built with legacy versions of SUNDIALS, but this MRI interface will only be "valid" starting from a specific SUNDIALS release. If this is possible, then I would like to update this "if" to ensure that the SUNDIALS release is at least the upcoming one (later this month).
There was a problem hiding this comment.
SUNDIALS_VERSION_AT_LEAST(major, minor, patch) is being added in #2990 so that could then be used as #if SUNDIALS_VERSION_AT_LEAST(7,2,0) if it will end up in 7.2.0
|
|
||
| #include "bout/bout_enum_class.hxx" | ||
| #include "bout/bout_types.hxx" | ||
| #include "bout/sundials_backports.hxx" |
There was a problem hiding this comment.
This #include will be unnecessary if the preprocessor guard is added above.
| rhs_ncalls_fe++; | ||
| rhs_ncalls_fi++; |
There was a problem hiding this comment.
Again, does this really want to increment both counters?
ARKODE MRI interface
An integrated test with ARKODE MRI interface