Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mpark.variant with std::variant #2851

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

Conversation

ZedThree
Copy link
Member

No description provided.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@dschwoerer
Copy link
Contributor

It seems std::variant is broken with old gcc versions?

I guess that we should delay this move for now?

It might also be good to check with intel compilers by the time we switch ...

@ZedThree
Copy link
Member Author

Bah, there is a C++17DR for making std::visit work when inheriting from std::variant. The fix is in gcc 11 and clang 15. This works fine in Intel.

So options are:

  1. hold off on this for now, which is pretty safe. I think mpark::variant even falls back to std::variant for C++17
  2. bump minimum compiler version required to gcc 11. This is mostly safe, most OSes with earlier versions are either EOL or close to EOL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants