Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: fix bug with testsys loglevel arg #92

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

webern
Copy link
Contributor

@webern webern commented Oct 3, 2023

Issue #, if available:

Fixes #75

Description of changes:

The --log-level argument was being passed incorrectly to testsys. This fixes it.

Testing:

In Bottlerocket:

cargo make -e TWOLITER_VERSION=97937a81fcce104faaa2b7464936de8261bcd0a4 \
  -e TWOLITER_REPO=https://github.com/webern/twoliter \
  -e TWOLITER_SKIP_VERSION_CHECK=true \
  -e TWOLITER_ALLOW_BINARY_INSTALL=false \
  -e TWOLITER_LOG_LEVEL=trace \
  test --help

This was broken before but worked with these changes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The --log-level argument was being passed incorrectly to testsys. This
fixes it.
@webern webern requested review from ecpullen and jpculp October 3, 2023 21:12
@webern webern merged commit cf47d30 into bottlerocket-os:develop Oct 3, 2023
1 check passed
@webern webern deleted the testsys-log-level-fix branch October 3, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants