Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsys: add image_id label at metal cluster crd #81

Merged
merged 1 commit into from
Sep 28, 2023
Merged

testsys: add image_id label at metal cluster crd #81

merged 1 commit into from
Sep 28, 2023

Conversation

gthao313
Copy link
Member

Issue #, if available:
#69
Description of changes:

testsys: add image_id label to fix metal cluster conflicts

When running metal conformance tests following migration tests, the metal crd for conformance wouldn't be created because it finds the cluster already has a crd. Therefore, the the in-appropriate Bottlerocket version would be tested.
The fix is to add new label imageID to the crd and make both crd unique, so the testsys will create two crds with right bottlerocket version to test conformance and migration.

Test
running metal conformance tests following migration tests and check bottlerocket label.

conformance test label

kubectl --kubeconfig testsys.kubeconfig -n testsys describe resource x86-64-metal-k8s-124-conformance
Name:         x86-64-metal-k8s-124-conformance
Namespace:    testsys
Labels:       testsys/arch=x86_64
              testsys/build-id=5ea1938a
              testsys/cluster=x86-64-metal-k8s-124
              testsys/controlPlaneEndpoint=10.80.50.122
              testsys/imageId=front_net_bottlerocket-metal-k8s-1_24-x86_64-1_15_0-5ea1938a
              testsys/k8sVersion=1.24
              testsys/test-type=conformance
              testsys/type=cluster
              testsys/variant=metal-k8s-1.24

migration test label

$ kubectl --kubeconfig testsys.kubeconfig -n testsys describe resource x86-64-metal-k8s-124-migration
Name:         x86-64-metal-k8s-124-migration
Namespace:    testsys
Labels:       testsys/arch=x86_64
              testsys/build-id=5ea1938a
              testsys/cluster=x86-64-metal-k8s-124
              testsys/controlPlaneEndpoint=10.80.50.122
              testsys/imageId=dfront_net_bottlerocket-metal-k8s-1_24-x86_64-v1_14_3_img_gz
              testsys/k8sVersion=1.24
              testsys/test-type=migration
              testsys/type=cluster
              testsys/variant=metal-k8s-1.24

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@webern webern mentioned this pull request Sep 28, 2023
5 tasks
@gthao313 gthao313 merged commit fcdf2c9 into develop Sep 28, 2023
1 check passed
@webern webern deleted the fix branch November 8, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants