twoliter: ensure krane tmpfile is deleted #420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using named tempfiles or tempdirs, the `tempfile` crate relies on Rust calling `drop()` in order to delete the created temporary files. We were using a static reference to a tempfile of the krane binary, which is not guaranteed to drop when the program completes. This caused twoliter to leak somewhat large krane binary tempfiles. This commit moves away from a static reference to the tempfile, instead improving ergonomics around ImageTool owning the tempfile reference. This allows the Rust compiler to more-reliably drop() the reference on exit.
|
I think the solution should be to unpack |
|
Closed in favor of #423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #417
Change Description:
When using named tempfiles or tempdirs, the
tempfilecrate relies on Rust callingdrop()in order to delete the created temporary files.We were using a static reference to a tempfile of the krane binary, which is not guaranteed to drop when the program completes. This caused twoliter to leak somewhat large krane binary tempfiles.
This commit moves away from a static reference to the tempfile, instead improving ergonomics around ImageTool owning the tempfile reference. This allows the Rust compiler to more-reliably drop() the reference on exit.
Testing done:
twoliterexecutions do not leak filesTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.