krane: write krane binary to a tempfile #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Berning <[email protected]>
cbgbt
approved these changes
Nov 8, 2024
tools/krane/Cargo.toml
Outdated
| @@ -11,6 +11,7 @@ anyhow.workspace = true | |||
| flate2.workspace = true | |||
| lazy_static.workspace = true | |||
| pentacle.workspace = true | |||
There was a problem hiding this comment.
I believe you can remove this dependency.
|
Too bad that the sealed file bit struggles on some systems -- it's still not clear to me why. Nice work! |
Signed-off-by: Sam Berning <[email protected]>
sam-berning
force-pushed
the
install-krane
branch
from
4c177ab to
2020d62
Compare
|
^ address comments from @cbgbt and update krane README |
cbgbt
approved these changes
Nov 8, 2024
sumukhballal
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #403
Description of changes:
While looking into #403, I noticed that the
kranebinary produced in the build works as expected if I just copy the binary over to an affected system.This PR changes the way that the
krane-bundlelib installs krane. Instead of keeping the file in memory and sealing it, we create a temp directory and write the krane binary to that directory.This PR also improves the error message when krane fails to run.
Testing done:
Built twoliter with
and copied the produced binary over to a system that was affected by the bug in #403. I ran
twoliter updatein the bottlerocket repo without issue.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.