attribution: upload dependency attributions as part of GitHub releases #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Sep 27, 2024
tools/attribution/attribution.sh
Outdated
| echo "Clarifying cargo-cross & dependency licenses..." | ||
| git clone https://github.com/cross-rs/cross/ /tmp/cargo-cross | ||
| pushd /tmp/cargo-cross | ||
| git reset --hard 7b79041 |
There was a problem hiding this comment.
Where do these two Git commit hashes come from? Can we pass them in as variables or in a config file?
There was a problem hiding this comment.
These commit hashes are what we lock to in the GitHub Actions workflow for performing a release. Per your other comment, I noted that we aren't distributing these tools with Twoliter and have just removed them from the attributions script!
tools/attribution/attribution.sh
Outdated
Comment on lines
43
to
48
| # =^.^= =^.^= =^.^= =^.^= =^.^= =^.^= =^.^= =^.^= =^.^= =^.^= =^.^= =^.^= =^.^= =^.^= | ||
| echo "Clarifying cargo-dist & dependency licenses..." | ||
| git clone https://github.com/webern/cargo-dist/ /tmp/cargo-dist | ||
| pushd /tmp/cargo-dist | ||
| git reset --hard 3dcbe823 | ||
| popd |
There was a problem hiding this comment.
Do cargo-cross and cargo-dist end up in the release artifacts in some way?
cbgbt
force-pushed
the
attribution-docs
branch
from
2962ac2 to
3981565
Compare
|
^ Removes |
bcressey
approved these changes
Oct 1, 2024
sam-berning
reviewed
Oct 1, 2024
Makefile
Outdated
| docker build \ | ||
| --build-arg BOTTLEROCKET_SDK_IMAGE=$(BOTTLEROCKET_SDK_IMAGE) \ | ||
| --build-arg UID=$(shell id -u) \ | ||
| --build-arg GID=$(shell id -u) \ |
There was a problem hiding this comment.
Suggested change
| --build-arg GID=$(shell id -u) \ | |
| --build-arg GID=$(shell id -g) \ |
cbgbt
force-pushed
the
attribution-docs
branch
from
3981565 to
c1edcd9
Compare
|
^ fixes bug found by @sam-berning |
sam-berning
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change:
license-scantool in the Bottlerocket SDK to generate attributions for 3rd party dependencies.Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.