Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for action releases and changelog updates #371

Merged

Conversation

sumukhballal
Copy link
Contributor

@sumukhballal sumukhballal commented Sep 16, 2024

Description of changes:

  1. Fixed and tested install-dist step in the release.yml file.
  2. Updated CHANGELOG.md to include latest changes for release.

Testing done:

Tested install-dist works as expected on my local branch build. https://github.com/sumukhballal/twoliter/actions/runs/10889775968/job/30217129584

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@cbgbt cbgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding #372 to the changelog as well?

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@sumukhballal
Copy link
Contributor Author

Addressed @cbgbt 's comments.

@sumukhballal sumukhballal requested a review from cbgbt September 16, 2024 20:57
@sumukhballal sumukhballal merged commit 1aa2f5c into bottlerocket-os:develop Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants