imghelper: hoist AWS vars into global environment #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When secure boot signing was refactored in 310cadd, the code that exports AWS credential variables into the global environment was moved into a bash function.
When used in a bash function, the
declare
keyword makes the declared symbol local, unless the -g option is also supplied. This adds the -g option to export the variables into the caller's environment as intended.Testing done:
Prior to this change, attempting to build with an AWS secureboot profile resulted in this error:
After this change, the build successfully retrieved the needed credentials and completed secureboot signing.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.