twoliter: create initial project with kits #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webern
reviewed
Dec 5, 2023
| path = "../variants.rs" | ||
|
|
||
| [build-dependencies] | ||
| hello-agent = { path = "../../kits/hello-kit" } |
There was a problem hiding this comment.
Suggested change
| hello-agent = { path = "../../kits/hello-kit" } | |
| hello-kit = { path = "../../kits/hello-kit" } |
Comment on lines
19
to
31
| # core | ||
| "release", | ||
| "kernel-6.1", | ||
| # docker | ||
| "docker-cli", | ||
| "docker-engine", | ||
| "docker-init", | ||
| "docker-proxy", | ||
| # tools | ||
| "login", | ||
| "iputils", | ||
| "strace", | ||
| "chrony-tools", |
There was a problem hiding this comment.
Suggested change
| # core | |
| "release", | |
| "kernel-6.1", | |
| # docker | |
| "docker-cli", | |
| "docker-engine", | |
| "docker-init", | |
| "docker-proxy", | |
| # tools | |
| "login", | |
| "iputils", | |
| "strace", | |
| "chrony-tools", | |
| "hello-agent", | |
| "hello-go", |
webern
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Can we name the projects in a self-documenting way? I would call this one local-kit.
Can you also add a README.md at the top of the local-kit project directory that explains that the purpose of the test project is to introduce a simple local kit project with no external kit dependencies?
webern
approved these changes
Dec 7, 2023
cbgbt
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #116
Description of changes:
Adds 2 new projects, 1 that bundles Bottlerocket into a
corekit, the other adds Bottlerocket packages as packages.Testing done:
N/A
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.