Skip to content

Commit

Permalink
buildsys: mark erofs feature as experimental
Browse files Browse the repository at this point in the history
erofs is a relatively new filesystem, especially when compared with
ext4. It shows promising results in terms of improved boot times, but
its behavior at runtime on fully loaded nodes is more difficult to
predict.

Mark the image feature as experimental for now. This allows it to be
enabled by downstream variants to facilitate additional experiments,
without immediately endorsing it for production use.

Signed-off-by: Ben Cressey <[email protected]>
  • Loading branch information
bcressey committed Sep 23, 2024
1 parent bf0e46e commit 8d45743
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions tools/buildsys/src/manifest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,11 @@ impl ManifestInfo {
}
}
}
for experiment in EXPERIMENTAL_IMAGE_FEATURES {
if features.contains(experiment) {
println!("cargo:warning=Image feature {experiment} is experimental; use at your own risk!");
}
}
Some(features)
}

Expand Down Expand Up @@ -797,6 +802,8 @@ pub enum ImageFeature {
HostContainers,
}

const EXPERIMENTAL_IMAGE_FEATURES: [&ImageFeature; 1] = [&ImageFeature::ErofsRootPartition];

impl TryFrom<String> for ImageFeature {
type Error = Error;
fn try_from(s: String) -> Result<Self> {
Expand Down

0 comments on commit 8d45743

Please sign in to comment.