ci: add secondary artifact support to PR build #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@etungsten this may be reasonable to tack along with the work to reorganize the Stacks (maybe?), do you think we should wait until those changes are merged / well-underway to coordinate making this change? |
I don't think we need to wait. These changes are small enough to incorporate. |
etungsten
approved these changes
Jan 7, 2020
|
@etungsten these changes will need to be made to the other stacks as well, if making that change in this PR isn't an issue then I'll go ahead and do that. |
Without this change, the script was prevented from writing in the correct build/meta directory as intended and was instead writing to the current directory.
jahkeup
force-pushed
the
ci-secondary-artifacts
branch
from
8d3a2ed
to
26c7306
Compare
|
Rebased on merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#604
Description of changes:
Added SecondaryArtifacts section to the Pull Request build CloudFormation Stack with the referenced ArtifactIdentifier to allow for uploading "meta" artifacts.
I've updated a stack in my own account and saw the change reflected. In the interest of keeping the artifacts separate from one another I've also renamed the output location for the Primary Artifacts - I didn't check to see if leaving it empty would cause CodeBuild to upload and later unpack from a shared
/where both the Secondary Artifacts lived (eg:/&/meta) and chose to avoid the situation altogether by giving them each their own key prefix (/build&/meta).Update: In the updated stack, a kicked-off build now has the primary and the secondary artifacts linked to.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.