Fix lingering containerd config issues #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f9784cb removed config.toml from factorydir but we didn't remove it from tmpfiles, which led to a "No such file" error at startup.
We already removed all of the CRI config in the dev image, but forgot to disable the plugin.
iliana
approved these changes
Dec 19, 2019
bcressey
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing done:
Made aws-k8s AMI, Kubernetes still connected and a pod worked, admin/sheltie worked. Made aws-dev AMI, admin/sheltie worked, ran a Docker container OK.
No longer see the above "No such file" error on startup.