Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor models to reduce duplication #591

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Refactor models to reduce duplication #591

merged 1 commit into from
Dec 17, 2019

Commits on Dec 17, 2019

  1. Refactor models to reduce duplication 

    To be able to have `models/lib.rs` with shared code, we needed to stop symlinking the entire `src` directory and instead treat the variant-specific code as Rust modules, symlinking the correct one to `variant::current` so that `lib.rs` can re-export `Settings`.  (We also have to symlink in `variant/mod.rs` so Rust knows it's part of the module hierarchy.)

Now, each variant defines a `Settings` structure using common sub-structures.  Those sub-structures live in the main `lib.rs`, and the modeled types are now in a shared `modeled_types` module.  No changes were made to the code, just its organization.

Documentation was updated to reflect these changes, including using cargo-readme to generate README.md now that there's a single source.
    @tjkirch
    tjkirch committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    5cf7da6 View commit details
    Browse the repository at this point in the history