-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable SELinux support #579
Conversation
Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dumb questions:
- glibc still has
--without-selinux
- is that related to building on hosts without SELinux? Or do we just not need it? - containerd, runc, docker, and cri-tools already had
selinux
inBUILDTAGS
- did Go have some special method for accomplishing that, or will it behave differently now, or...? - You're confident that we can't / shouldn't add support in other packages? (Nothing jumps out at me, but I'm not a SELinux person. Maybe findutils?)
I need to dig into what glibc uses its SELinux support for. It's a bootstrapping challenge since we need glibc to build libselinux, which we'd then need to build glibc. I could handle this as part of building the SDK but it's not very elegant.
These all use the native Go implementation in
|
glibc can build |
Issue #, if available:
N/A
Description of changes:
This adds the SELinux libraries and enables support in the packages we ship.
Testing done:
ps
,ls
could show security context.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.