updog: Add support for query parameters in TUF requests #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And you can bikeshed the transport name, it was too fun not to include in the PR 😄 |
tjkirch
reviewed
Nov 20, 2019
|
Updated to set query parameters and pass to an inner HttpTransport, and changed the name to HttpQueryTransport / HttpQueryRepo. |
tjkirch
approved these changes
Nov 21, 2019
tjkirch
approved these changes
Dec 5, 2019
tjkirch
approved these changes
Dec 6, 2019
Implement a new tough transport 'Bark', which allows Updog to add extra query parameters to requests to the TUF repository. Updog now uses this to append the current image version to all requests. Signed-off-by: Samuel Mendoza-Jonas <[email protected]>
|
Rebase to handle Cargo.toml conflict |
iliana
approved these changes
Dec 6, 2019
| @@ -274,6 +274,12 @@ pub(crate) enum Error { | |||
| source: std::io::Error, | |||
| }, | |||
|
|
|||
| #[snafu(display("2Borrow2Fast"))] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#459
Description of changes:
Implement a new tough transport 'Bark', which allows Updog to add extra
query parameters to requests to the TUF repository.
Updog now uses this to append the current image version to all requests.
Signed-off-by: Samuel Mendoza-Jonas [email protected]
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tested by launching an instance, performing Updog commands, and observing the extra query parameters in the TUF repository access logs.