-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrations: Adds new migration for bumping host container versions #536
Conversation
workspaces/api/migration/migrations/v0.1/host-containers-version/src/main.rs
Outdated
Show resolved
Hide resolved
workspaces/api/migration/migrations/v0.1/host-containers-version/src/main.rs
Outdated
Show resolved
Hide resolved
workspaces/api/migration/migrations/v0.1/host-containers-version/src/main.rs
Outdated
Show resolved
Hide resolved
workspaces/api/migration/migrations/v0.1/host-containers-version/src/main.rs
Outdated
Show resolved
Hide resolved
8804779
to
95d702a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This migration should be under migrations/v0.2 right?
Addresses @tjkirch 's comments: Tests still pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah wait, we're going from 0.0 -> 0.1, all good ;)
workspaces/api/migration/migrations/v0.1/host-containers-version/src/main.rs
Outdated
Show resolved
Hide resolved
Adds migration for bumping the default admin and control container versions from 0.1 to 0.2
95d702a
to
a55cd4f
Compare
Addresses @tjkirch 's comments on constant use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏙
Adds migration for the default admin and control container versions v0.1 <-> v0.2
Issue #, if available: #534
Description of changes:
Testing done:
Locally testing forward migration, and it bumps version correctly from v0.1 to v0.2:
Run again:
If the admin container is a custom container, no modification is made:
For control container, same, bumps version correctly from v0.1 to v0.2:
For backwards migration, admin downgrades from v0.2 to v0.1:
Backwards control container version migration:
Tested in live Thar instance, launched Thar v0.1.6 (datastore version v0.0), loaded new image into side B using
dd
, loaded migrations, ran updates and verified that default image versions got bumped:By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.