-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: Adds a Sonobuoy conformance testing script #530
Conversation
b57a486
to
e979252
Compare
Talked with @etungsten a bit outside of the PR. I think we should aim for separating the setup and run portions. That way developers can leave the infrastructure and just do a quick test run when desired, and CI can spin up fresh as needed. |
e979252
to
7850494
Compare
Split the monolithic script into three parts: |
7850494
to
f24b6c3
Compare
Would you please update the testing for the new script separation? (I don't think we need to see two regions; your assurance that it works the same is enough there :)) |
f24b6c3
to
6b11939
Compare
6b11939
to
80414cb
Compare
Updated testing description. |
|
||
echo "Setting up fresh EKS cluster with eksctl" | ||
eks_cluster_creation_attempted=true | ||
eksctl create cluster -r "${REGION}" --zones "${ZONES}" -n "${CLUSTER_NAME}" --nodes 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does --nodes 0
here cause eksctl
to setup the nodegroup resources without starting nodes? Does it create an ASG that can later be scaled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it does! Yes it does!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chatted with @etungsten offline: the ASG aspect won't be useful to us until we have an eksctl
in place that has the desired CNI plugin configured (for aws-node
) and the TOML userdata generation.
In talking with @tjkirch about how #363 could help reduce scope, I think we came to an understanding that it would be reasonable to rely on a patched version if the upstream gave positive indications that they'd accept thar
node-ami-family
contributions. Please correct me if I misunderstood @tjkirch 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In talking with @tjkirch about how #363 could help reduce scope, I think we came to an understanding that it would be reasonable to rely on a patched version if the upstream gave positive indications that they'd accept thar node-ami-family contributions. Please correct me if I misunderstood @tjkirch
I think that's a minimum requirement, but we should still discuss with the team to make sure we'd want to suggest that (1) users need a patched tool, or (2) we have branching instructions.
80414cb
to
ec611d4
Compare
Removes setting up a completely new instance profile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review - I think GitHub is preventing me from responding to other comments because I have these pending..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! There's a few scripty things I had questions on as well as sonobouy result outputs that I want to understand a bit more.
ec611d4
to
44e84d8
Compare
6318744
to
9b98362
Compare
9b98362
to
2da8dd3
Compare
Redirect |
58b9c46
to
dc41822
Compare
05db246
to
d418c97
Compare
GitHub merged force-pushes; here's the full diff from the changes etungsten made 2019-11-27: https://github.com/amazonlinux/PRIVATE-thar/compare/231ef76..d418c97 |
d418c97
to
3bba8a5
Compare
Addresses @tjkirch 's comments:
Testing again to make sure everything still works. |
3bba8a5
to
7bfee06
Compare
7bfee06
to
4f64f01
Compare
Addresses @tjkirch 's comments. |
4f64f01
to
a07daef
Compare
7fb4f86
to
91190b8
Compare
Removes the added security group egress and security group ingress rules during clean up. |
91190b8
to
e5f029f
Compare
Addresses @tjkirch's comment |
e5f029f
to
f7e7694
Compare
Adds sonobuoy conformance testing scripts that spins up EKS clusters and several thar worker nodes then runs sonobuoy conformance testing, after its done, it retrieves the results and spins down the EKS cluster.
f7e7694
to
a4496e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Let's get going with this and revisit if needed. 👍
Issue #, if available: N/A
Description of changes:
Adds sonobuoy conformance testing scripts that spins up an EKS cluster
then runs sonobuoy conformance testing, after its done, it retrieves the
results and spins down the EKS cluster.
setup-test-cluster.sh
sets up the cluster and generates env file and user datarun-conformance-test.sh
consumes the generated env file and user data to launch thar worker nodes and runs sonobuoy conformance tests.clean-test-cluster.sh
cleans up the test cluster specified by the env file.Borrows several helper functions from the
amiize.sh
script.Testing:
Running in us-west-2:
Setup cluster:
Run conformance tests:
Clean up cluster:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.