apiclient: error on non-2xx response

[etungsten]

Issue #, if available: Fixes #489

Description of changes: Adds a new error type for when response code is not in the 2xx range

Testing:

Launched Thar instance, from the admin container:

bash-5.0# apiclient -u /settings/gibberish
Error: ResponseStatus { code: 404, uri: unix://2f72756e2f6170692e736f636b:0/settings/gibberish }

bash-5.0# echo $?                         
1
                                                                                       
bash-5.0# apiclient -u /settings
{"timezone":"America/Los_Angeles","hostname":"localhost","kubernetes":{"cluster-name":"thar-testing-grounds",
...

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[tjkirch]

LGTM. Would you please show $? in the testing though, since the goal is making sure that's not 0? (You can test the client locally, don't need a full build)

[etungsten]

Addresses @tjkirch 's comments:
Updated display trait for ResponseStatus

[etungsten]

LGTM. Would you please show $? in the testing though, since the goal is making sure that's not 0? (You can test the client locally, don't need a full build)

Got 1 for the exit code. Updated PR testing description.

bash-5.0# apiclient -u /settings/gibberish
Error: ResponseStatus { code: 404, uri: unix://2f72756e2f6170692e736f636b:0/settings/gibberish }
bash-5.0# echo $?                         
1

[zmrow]

🐢