-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[storewolf] Improve default metadata representation #491
Conversation
#[snafu(display("Internal error: {}", msg))] | ||
Internal { msg: String }, | ||
|
||
#[snafu(display("Keys can't contain newlines: {}", source))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this error message just duplicates what's going to be in the source error; it might be better to give a pointer to the input that unexpectedly contained a newline. The path
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌲
Addressed comments from @tjkirch |
This commit improves how metadata is represented in our defaults.toml. Previously each metadata entry required a seperate 4 line declaration, which is noisy and unpleasant. With this change, metadata for each corresponding setting can be defined together in a single metadata entry. The commit adds a single function to translate this new defaults toml format into a Vec<Metadata> which is processed in storewolf exactly the same as we did previously.
Fixed error text per @tjkirch ! |
Oh - and rebased as well. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval stands!
This commit improves how metadata is represented in our defaults.toml.
Previously each metadata entry required a seperate 4 line declaration,
which is noisy and unpleasant. With this change, metadata for each
corresponding setting can be defined together in a single metadata
entry.
The commit adds a single function to translate this new defaults toml
format into a Vec which is processed in storewolf exactly
the same as we did previously.
*Please closely double check my edits of defaults.toml!
Issue #, if available:
Fixes #135
Description of changes:
Testing done
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.