Fix modeled_types tests #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests were failing because the model changed to using SingleLineString but tests weren't updated and were still using String. This updates modeled_types to use TryFrom as the primary source of conversion logic, delegating to it in Deserialize. This simplifies using the new types in tests, and tests our logic rather than serde. Controller tests can then use try_into to get the expected type. Because we're no longer diverting through serde, we no longer need to awkwardly quote data strings in the tests.
|
This push fixes tests in thar-be-settings that also used SingleLineString. I confirmed that all first-party tests are now passing. |
iliana
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were failing because the model changed to using SingleLineString but
tests weren't updated and were still using String.
This updates modeled_types to use TryFrom as the primary source of conversion
logic, delegating to it in Deserialize. This simplifies using the new types in
tests, and tests our logic rather than serde. Controller tests can then use
try_into to get the expected type.
Because we're no longer diverting through serde, we no longer need to awkwardly
quote data strings in the tests.
Sorry, I didn't catch this because tests stopped running during build.
Tests now pass.