v0.1.6 #440
v0.1.6 #440
Conversation
CHANGELOG.md
Outdated
|
|
||
| ## OS changes | ||
|
|
||
| * The system fetches the pause container from ECR before starting `kubelet` (#382). |
There was a problem hiding this comment.
All looks good! For the PR numbers, should we make these actual links to those PRs, or instead mention the commit the change was introduced in?
There was a problem hiding this comment.
I think if you're viewing the changelog on github.com it'll render the links automatically?
There was a problem hiding this comment.
It doesn't in the rich diff but maybe that's just when it's a PR?
There was a problem hiding this comment.
Good point, I think if we move away from the PR number I would have us link to the merge commits at least. This'll give us "portable" references as well as local references.
There was a problem hiding this comment.
PR links would be best; should we just try it as-is and change it if they don't render? (If they don't, it'll have to be absolute links anyway, so I'd still go with PR links... you want to be able to see the change and the discussion, not just the final result.)
There was a problem hiding this comment.
Relative links should work though? https://stackoverflow.com/questions/20097938/github-linking-to-an-issue-from-a-wiki-page
There was a problem hiding this comment.
There was a problem hiding this comment.
The relative links make me sad using anything other than Github..
There was a problem hiding this comment.
We could possibly do something like this...
blah blah blah [#123]
[#123]: ../../pull/123... this is done in the latest force-push (21a098d).
There was a problem hiding this comment.
That's not going to avoid problems of relative to Github so much as cleanliness. I'm as okay with the "named" link as much as the inlined relative url. Having a ref to the merge commit or the tip of the merged-PR is a preference - I'd say we should stick to the #123 format here unless the link is going to act differently. This also would be confusing when used in READMEs in subdirectories where the relative URL won't be ../...
iliana
force-pushed
the
release/v0.1.6
branch
2 times, most recently
from
90d81a6
to
21a098d
Compare
Signed-off-by: iliana destroyer of worlds <[email protected]>
Co-Authored-By: Tom Kirchner <[email protected]>
Signed-off-by: iliana destroyer of worlds <[email protected]>
Signed-off-by: iliana destroyer of worlds <[email protected]>
iliana
force-pushed
the
release/v0.1.6
branch
from
21a098d
to
5a09294
Compare
|
🍶 |
🎉 release notes time 🎉
The release notes imply #434 and #435 are landing and nothing else is landing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.