Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host-ctr: fix references for non-ECR images #439

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Conversation

etungsten
Copy link
Contributor

Discovered this bug when I was working on #433.

Issue #, if available: n/a

Description of changes: Fixes a bug introduced in #382 where ref isn't set when pulling images from non-ECR registries

Testing:
Before the fix:

$ sudo ./host-ctr -source registry.hub.docker.com/library/busybox:latest -pull-image-only -containerd-socket /run/containerd/containerd.sock
ERRO[0000] Failed to pull ctr image: failed to resolve reference "": hostname required  ref=

Now can pull images from docker hub, etc and not just ECR:

$ sudo ./host-ctr -source registry.hub.docker.com/library/busybox:latest -pull-image-only -containerd-socket /run/containerd/containerd.sock
INFO[0000] Pulled successfully                           img="registry.hub.docker.com/library/busybox:latest"
INFO[0000] Unpacking...                                  img="registry.hub.docker.com/library/busybox:latest"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Fixes a bug introduced in #382 where `ref` isn't set when pulling images from
non-ECR registries
@etungsten etungsten merged commit f2d610e into develop Oct 21, 2019
@etungsten etungsten deleted the host-ctr-fix-ref branch October 21, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants