Portback apiclient feature flags #4272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginglis13
approved these changes
Oct 29, 2024
bcressey
reviewed
Oct 29, 2024
sources/deny.toml
Outdated
Comment on lines
68
to
69
| # reqwest brings a set of new dependencies | ||
| { name = "reqwest", version = "=0.12" }, |
There was a problem hiding this comment.
this is a pretty unhelpful comment - why are we skipping all of reqwest's dependencies?
Generally we should only do this if we're including multiple versions of a crate, and we would do this to the older one which is presumably less likely to change in a significant way. But here we still only have one copy of reqwest.
Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
Add `tls` feature flag to allow consumers of the crate opt-in to TLS connections when required. Additionally, add `fips` feature flag to constrain any TLS connection to FIPS ciphers. Signed-off-by: Arnaldo Garcia Rincon <[email protected]> Signed-off-by: Ben Cressey <[email protected]> (cherry picked from commit d56cc898dd6b03702ef3ec49e1c64b1ec4274718) Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
arnaldo2792
force-pushed
the
portback-apiclient
branch
from
c397340
to
e5c8007
Compare
|
Forced push fixes:
|
bcressey
approved these changes
Nov 1, 2024
cbgbt
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N / A
Description of changes:
In bottlerocket-os/bottlerocket-core-kit#173, two feature flags were added to
apiclientin order to support FIPS binaries. Lets port them back to this repo to make keep both repos in sync. I cherry-picked the commit and adjusted as necessary.Testing done:
aws-ecs-2and confirmed the host joins a cluster and tasks runTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.