Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to core-kit 3.0.0 #4251

Merged

Conversation

ytsssun
Copy link
Contributor

@ytsssun ytsssun commented Oct 18, 2024

Description of changes:

  • Bump Twoliter version to 0.5.0.
  • Bump core-kit version to 3.0.0.
  • Bump SDK version to 0.46.0.
  • Update nvidia kmod name from kmod-5.10-nvidia-tesla-470 to
    kmod-5.10-nvidia-tesla-535. The Bottlerocket core kit 3.0.0 changes the name of the kmod-5.10-nvidia tesla package from kmod-5.10-nvidia-tesla-470 to kmod-5.10-nvidia-tesla-535 due to the NVIDIA branch offered by this package. This change only affects one variant and is done on a major version bump for the core kit.
  • Fix clippy errors.

Testing done:

  • cargo make unit-tests
  • cargo make check-fmt
  • cargo make check-clippy
  • cargo make check-shell
  • cargo make -e BUILDSYS_VARIANT=aws-k8s-1.24

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Now that krane builtin to twoliter, we don't need special instructions
for the containerd-snapshotter in the docker daemon.
@ytsssun ytsssun requested a review from cbgbt October 18, 2024 21:15
Copy link
Contributor

@cbgbt cbgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though as a nit I'd include the core-kit & SDK versions in the commit message.

ytsssun and others added 2 commits October 18, 2024 21:30
- Also fix clippy warning.

Signed-off-by: Yutong Sun <[email protected]>
The Bottlerocket core kit 3.0.0 changes the name of the kmod-5.10-nvidia
tesla package from kmod-5.10-nvidia-tesla-470 to
kmod-5.10-nvidia-tesla-535 due to the NVIDIA branch offered by this
package.

Signed-off-by: Matthew Yeazel <[email protected]>
@ytsssun ytsssun force-pushed the twoliter-and-core-kit-update-3.0.0 branch from 5e19713 to 8d1b1f8 Compare October 18, 2024 21:31
@ytsssun ytsssun changed the title Twoliter and SDK and Core Kit update 3.0.0 Update to core-kit 3.0.0 Oct 18, 2024
Copy link
Contributor

@cbgbt cbgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@yeazelm yeazelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the builds pass!

@ytsssun ytsssun merged commit ae72e1f into bottlerocket-os:develop Oct 18, 2024
2 checks passed
@KCSesh KCSesh mentioned this pull request Oct 23, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants