tuftool: Warn before downloading root.json #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliana
reviewed
Oct 16, 2019
|
When does this happen? The user has to pass some horrible-sounding flag to allow downloading root without being able to verify it, right? |
This happens if calling |
If the user doesn't provide a root.json require the --allow-root-download flag before downloading a remote root.json, and follow it up with a big warning. Fixes #353 Signed-off-by: Samuel Mendoza-Jonas <[email protected]>
|
Updated to loudly warn the user instead and require a flag to be set. |
tjkirch
approved these changes
Oct 16, 2019
Use AsRef<Path> for root_warning() Co-Authored-By: Tom Kirchner <[email protected]>
iliana
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #353
Description of changes:
Make the user acknowledge a warning before downloading a root.json file.
Signed-off-by: Samuel Mendoza-Jonas [email protected]
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.