Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog: update for 1.23.0 release #4191

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

yeazelm
Copy link
Contributor

@yeazelm yeazelm commented Sep 12, 2024

Issue number:

Related to #4190

Description of changes:
Update the changelog for the 1.23.0 release.

Testing done:
N/A

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

CHANGELOG.md Outdated
* Update bottlerocket-sdk to 0.45 ([#4189])

### Kit Changes
* Update to bottlerocket-core-kit to v2.5.0 ([#4189])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "Update to ... to" is awkward. Removing the first "to" would make it resemble "Update bottlerocket-sdk to...."

@arnaldo2792
Copy link
Contributor

We want to include #4203

@arnaldo2792 arnaldo2792 marked this pull request as draft September 18, 2024 02:12
@arnaldo2792 arnaldo2792 force-pushed the 1_23_0_changelog branch 2 times, most recently from 2c4abc2 to a2f9a5a Compare September 18, 2024 22:13
@arnaldo2792 arnaldo2792 marked this pull request as ready for review September 18, 2024 22:21
CHANGELOG.md Outdated
* Update bottlerocket-core-kit to v2.5.0 ([#4189])
* Perform binary checksum validation ([#4192])
* Update Twoliter to v0.4.6 ([#4200])
* Update bottlerocket-core-kit to v2.6.0 ([#4203])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we merge both Core kit releases and say "Update bottlerocket-core-kit to v2.6.0 ([#4189], [#4203])"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I can do that without calling out the version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While updating the website I check the changelog to get the core-kit version. I would prefer the mention of the version in one of the lines.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference: #4157

@piyush-jena
Copy link
Contributor

Apart from @vyaghras ' comment, nothing else to call out.

Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
@arnaldo2792 arnaldo2792 merged commit 6ac4c13 into bottlerocket-os:develop Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants