-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove indirect project dependencies #3279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a few dependencies listed in the apisever Cargo.toml file that are not direct dependencies of the project. These may be indirect dependencies, but they should not be explicitly called out in the Cargo.toml file if they are not being directly used. Signed-off-by: Sean McGinnis <[email protected]>
Removes indirect dependencies from the bootstrap-containers Cargo.toml file. Signed-off-by: Sean McGinnis <[email protected]>
Removes transient dependencies from being listed in the certdog Cargo.toml file. Signed-off-by: Sean McGinnis <[email protected]>
This removes indirect dependencies from the corndog Cargo.toml file. Signed-off-by: Sean McGinnis <[email protected]>
This removes indirect dependencies from the datastore Cargo.toml file. Signed-off-by: Sean McGinnis <[email protected]>
This removes indirect dependencies from the host-containers Cargo.toml file. Signed-off-by: Sean McGinnis <[email protected]>
This removes indirect dependencies from the migration-helpers Cargo.toml file. Signed-off-by: Sean McGinnis <[email protected]>
This removes indirect dependencies from the migrator Cargo.toml file. Signed-off-by: Sean McGinnis <[email protected]>
This removes indirect dependencies from the settings-committer Cargo.toml file. Signed-off-by: Sean McGinnis <[email protected]>
This removes indirect dependencies from the static-pods Cargo.toml file. Signed-off-by: Sean McGinnis <[email protected]>
This removes indirect dependencies from the sundog Cargo.toml file. Signed-off-by: Sean McGinnis <[email protected]>
This removes indirect dependencies from the cfsignal Cargo.toml file. Signed-off-by: Sean McGinnis <[email protected]>
This removes indirect dependencies from the imsdclient Cargo.toml file. Signed-off-by: Sean McGinnis <[email protected]>
This removes indirect dependencies from the model-derive Cargo.toml file. Signed-off-by: Sean McGinnis <[email protected]>
This remove indirect dependencies from the updog Cargo.toml file. Signed-off-by: Sean McGinnis <[email protected]>
etungsten
approved these changes
Jul 21, 2023
jpculp
approved these changes
Jul 21, 2023
arnaldo2792
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Several projects had dependencies listed in their
Cargo.toml
files that were not actually direct dependencies. As far as I could see, most of these were transient dependencies (dependencies of dependencies) that get pulled into theCargo.lock
file without needing to explicitly include them inCargo.toml
. This could result in pulling in, and building, a dependency that is no longer needed by the direct dependency that originally needed it.This cleans up all identified instances to make sure we are only declaring what we directly need in each project.
Testing done:
Checked for extra dependencies with
cargo machete
.Verified after removing dependencies that the project could still build:
Checked for any issues with
cargo make check
.Built
aws-k8s-1.26
variant and deployed cluster node. Verified new node showed up healthy in the cluster.Connected to node via SSM and ran several
apiclient
commands to make sure things were operating as expected:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.