ci: use intermediate env vars for commitlint job #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI build license error fixed in this PR: #68 |
koooosh
force-pushed
the
fix-commitlint
branch
from
8bdffa2 to
bc5fab4
Compare
koooosh
force-pushed
the
fix-commitlint
branch
from
bc5fab4 to
70dd280
Compare
|
^ Force push removes the quotes around individual env vars for the |
yeazelm
reviewed
Dec 10, 2024
Signed-off-by: Kush Upadhyay <[email protected]>
koooosh
force-pushed
the
fix-commitlint
branch
from
70dd280 to
e8f3e2d
Compare
|
^ Force push adds consistent formatting for all env vars |
KCSesh
approved these changes
Dec 10, 2024
yeazelm
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #66
Description of changes:
The current commitlint workflow (specifically this step) takes raw user-controlled input.
This PR updates the impacted step to use intermediate environment variables for the user-controlled input, follow this best practice.
Testing
Sample run
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.