kubernetes: add max_parallel_image_pulls and serialize_image_pulls #59
Conversation
Signed-off-by: Gavin Inglis <[email protected]>
ginglis13
force-pushed
the
parallel-image-pulls
branch
from
a11fe65 to
ebac9f2
Compare
| // Generated in `k8s-1.27+` variants only | ||
| serialize_image_pulls: bool, | ||
| max_parallel_image_pulls: i32, |
There was a problem hiding this comment.
Are these values not supported on older versions of kubelet?
If we add them like this, they'll still be in the settings API for older *-k8s-* builds.
There was a problem hiding this comment.
Correct, this feature landed in k8s-1.27: https://kubernetes.io/docs/concepts/containers/images/#maximum-parallel-image-pulls.
If we add them like this, they'll still be in the settings API for older -k8s- builds.
Also correct - my thought was that these settings would be ignored/unused in k8s < 1.27, and only included in a kubelet-config in kubernetes-1.27+ packages. We'd call out this distinction on the bottlerocket.dev Settings Index
Open to suggestions on a better approach here, though
There was a problem hiding this comment.
I think it makes sense to include the settings and document that they are ignored in older versions. Adding settings gated by a feature flag caused a few issues when we did it for nvidia-device-plugin settings, and in this case I don't think it makes sense to add a kubernetes-1.27+ top-level setting.
Issue #, if available:
bottlerocket-os/bottlerocket#4058
Description of changes:
Add support for the
serializeImagePullsandmaxParallelImagePullskubelet config settings: https://kubernetes.io/docs/concepts/containers/images/#maximum-parallel-image-pullsonce merged and release, I have changes staged for bottlerocket-core-kit to pass through the setting that I'll PR. Currently testing those.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.