Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken Polly example #3300

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

SamRemis
Copy link
Contributor

Fixes Boto3 #4920

The examples in Polly's docs is misleading; the current suggested input is for content is file://example.pls, but that will cause the literal string of file://example.pls to be uploaded as the content, resulting in the following error:

InvalidLexiconException: An error occurred (InvalidLexiconException) when calling the PutLexicon operation: Invalid PLS Lexicon

Polly expects this input to be a lexicon as defined by the PLS specificiation. This PR is to make it clearer that we will not open and retrieve the file contents on behalf of the customer, and that they must provide the contents of the pls directly.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (b1279af) to head (446ae42).
Report is 99 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3300   +/-   ##
========================================
  Coverage    93.18%   93.18%           
========================================
  Files           66       66           
  Lines        14345    14375   +30     
========================================
+ Hits         13367    13396   +29     
- Misses         978      979    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alexgromero alexgromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@SamRemis SamRemis merged commit 2f81898 into boto:develop Nov 18, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polly's put_lexicon() example does not work
3 participants