-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typing: src/vorta/store
#1872
Open
SAMAD101
wants to merge
22
commits into
borgbase:master
Choose a base branch
from
SAMAD101:issue1870
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
typing: src/vorta/store
#1872
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
6abd0f5
added peewee to requirements.d/dev.txt
SAMAD101 7b80066
removed peewee from requirements: not necessary
SAMAD101 5f07abd
Merge branch 'borgbase:master' into master
SAMAD101 b4f2e64
Merge branch 'borgbase:master' into master
SAMAD101 4b299f9
Merge branch 'borgbase:master' into master
SAMAD101 d21316b
Merge branch 'borgbase:master' into master
SAMAD101 4f03af6
Merge branch 'borgbase:master' into master
SAMAD101 767dcc1
Merge branch 'borgbase:master' into master
SAMAD101 1d76358
Merge branch 'borgbase:master' into master
SAMAD101 a5c6729
Merge branch 'borgbase:master' into master
SAMAD101 2f40b7c
Merge branch 'borgbase:master' into master
SAMAD101 77f5c33
add peewee
SAMAD101 f0f33c7
made store/ typesafe
SAMAD101 5f5b4e3
made store/ typesafe
SAMAD101 0c3829c
conflict resolved
SAMAD101 eee0b42
conflict resolved
SAMAD101 65fa36b
minor refactor in src/vorta/store/connection.py
SAMAD101 bef54e1
Merge branch 'borgbase:master' into issue1870
SAMAD101 73e7d96
chore: minor refactor
SAMAD101 8d4ed3b
Merge branch 'master' into issue1870
real-yfprojects ba695dd
Merge branch 'borgbase:master' into issue1870
SAMAD101 59803e6
chore: minor refactor
SAMAD101 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is proper use of type hints. Shouldn't it be the following instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last_scheduled_backups_per_profile
just a bit below (line 71) was assigned like that ( = Tuple(...)) so, I did it tolast_backups_per_profile
for consistency. I think it would be better to do it according to your suggestion or keep both like: