Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rclone backend: retry errors on load and store 3 times #56

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

ncw
Copy link
Contributor

@ncw ncw commented Sep 25, 2024

Rclone internally retries requests, but not ones which stream data,
like load and store.

Since we have the data for load and store buffered in memory it is
easy to retry them.

The rclone server returns 500 errors for backend errors or internet
errors or protocol errors which might be fixed with a retry.

PS This is a followup from this comment #46 (comment)

Rclone internally retries requests, but not ones which stream data,
like load and store.

Since we have the data for load and store buffered in memory it is
easy to retry them.

The rclone server returns 500 errors for backend errors or internet
errors or protocol errors which might be fixed with a retry.
@ThomasWaldmann ThomasWaldmann merged commit 7e36330 into borgbackup:master Sep 26, 2024
7 checks passed
@ThomasWaldmann
Copy link
Member

Thanks for the PR!

BTW, if you want to try borg "in action" with rclone, I just released borg 2.0.0b11 (python pypi packages + some fat binaries):

https://github.com/borgbackup/borg/releases/tag/2.0.0b11

@ncw ncw deleted the fix-rclone-retries branch September 26, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants