rclone backend: fix hang on termination #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change the rclone backend was creating a non daemon thread which was hanging borgstore when it quit without closing the backend. This patch changes the thread into a daemon thread which won't stop the program from exiting when the thread is running. Fixes borgbackup#54
ThomasWaldmann
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
LGTM!
I've tested this and it fixes #54.
Not sure why though, because the repository context manager in borg closes the store, so guess it must be some other reason.
Great!
It is probably racing with the thread or something like that. Anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change the rclone backend was creating a non daemon thread
which was hanging borgstore when it quit without closing the backend.
This patch changes the thread into a daemon thread which won't stop
the program from exiting when the thread is running.
Fixes #54