driver-architecture: bus infrastructure is itself a framework #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is explained much later in the training, but I think it's important to mention this early on already. Otherwise, things that are explained immediately afterwards don't make much sense (e.g. the fact that you have a struct device twice: once for the bus and once for the functional framewoek). Signed-off-by: Arnout Vandecappelle <[email protected]>
miquelraynal
requested changes
May 6, 2024
There was a problem hiding this comment.
It is totally true we don't explain well the fact that we have in the end several struct devices for the same physical device, but:
- it's not always the case (welcome in the kernel world)
- it feels way too early here before we can talk about this
However I would suggest to add your modified figure when we talk about the device model being recursive? We could maybe even have a bit of text explaining the double struct device thing there. This way the learning curve is not too steep at the very beginning.
|
Hello @arnout, are you planning to update your PR with @miquelraynal 's suggestion ? |
|
It's been too long ago and I no longer have the context to understand what I was even trying to do here... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is explained much later in the training, but I think it's important to mention this early on already. Otherwise, things that are explained immediately afterwards don't make much sense (e.g. the fact that you have a struct device twice: once for the bus and once for the functional framewoek).
While using the bootlin materials for an internal training, there are a few improvements I made (at least, I consider them improvments myself). Since you probably don't agree with all of them, I'm making separate PRs for each. Feel free to close the PR if you disagree with the idea.