web: Range state from url #338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fstachura
force-pushed
the
range-state-from-url
branch
from
be8ff2a
to
d3c05d9
Compare
fstachura
force-pushed
the
range-state-from-url
branch
from
d3c05d9
to
6fd1465
Compare
Important changes that should make reading the diff easier: * Script now only works on line numbers. Elements are queried when necessary * handleLineRange was refactored into functions that only validate and return line number(s), it's now the callers responsibility to highlight the range
|
If we modify the URL bar and change the anchor, the webpage does not update. Is that expected? Do we have events accessible for that? Example:
|
I guess
If you find this valuable, there is a hashchange event that can be used to update range if someone types a hash manually |
fstachura
force-pushed
the
range-state-from-url
branch
from
6fd1465
to
04d882a
Compare
|
@tleb Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #329