Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

range anchors: allow selecting when arriving on page with single-line anchor #329

Open
tleb opened this issue Sep 15, 2024 · 0 comments · May be fixed by #338
Open

range anchors: allow selecting when arriving on page with single-line anchor #329

tleb opened this issue Sep 15, 2024 · 0 comments · May be fixed by #338

Comments

@tleb
Copy link
Member

tleb commented Sep 15, 2024

The JS stores previous clicks to know the current selection state. That means that when we land on a page with an anchor, our page's state doesn't contain the initial line as selected.

Can you confirm the proposed behavior is more intuitive? I did it without thinking when landing on the above page.

fstachura added a commit to fstachura/elixir that referenced this issue Sep 20, 2024
fstachura added a commit to fstachura/elixir that referenced this issue Sep 23, 2024
fstachura added a commit to fstachura/elixir that referenced this issue Sep 27, 2024
@fstachura fstachura linked a pull request Sep 27, 2024 that will close this issue
fstachura added a commit to fstachura/elixir that referenced this issue Sep 27, 2024
fstachura added a commit to fstachura/elixir that referenced this issue Oct 8, 2024
tleb pushed a commit that referenced this issue Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant