Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#477 and #178 Misc bugfixes and small edits to the initial Version/Library import and the monthly refresh #481

Merged
merged 10 commits into from
Jul 10, 2023

Conversation

williln
Copy link
Collaborator

@williln williln commented Jul 5, 2023

Closes #477. Part of #178.

  • Skip versions prior to 1.0 -- those don't include the libraries in .gitmodules and there is not currently another way to get that data
  • Make library and version on LibraryVersion required
  • When adding library-versions, if the library doesn't exist, refactored to add the library instead of skipping it
  • Some minor bugfixes
  • Some minor refactoring to make running the commands and understanding the code easier, including making update_library() more generic and only updating the db, and moving the other update methods to within the loop in update_libraries(). Also added calls to get PR and issue data that were missing before (methods were there, just not called), but commented it out. It's data that takes a long time to pull, so we may want to either break up the process into celery tasks, or add logic to handle rate limiting, or both. CC @4down @frankwiles since this PR/commit data appears on the new homepage I think?
  • Refactor to get all commit data on the initial load (./manage.py update_libraries), but only the most recent month in the monthly refresh task

@williln williln marked this pull request as ready for review July 6, 2023 00:00
@williln williln requested a review from frankwiles July 6, 2023 00:07
@williln williln changed the title 178 regular refresh #477 and #178 Misc bugfixes and small edits to the initial Version/Library import and the monthly refresh Jul 6, 2023
@williln williln merged commit 91a1936 into develop Jul 10, 2023
4 checks passed
@williln williln deleted the 178-regular-refresh branch July 10, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Libraries in versions of Boost older than 1.0.0 don't fully load
1 participant