Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News styling #480

Merged
merged 20 commits into from
Jul 5, 2023
Merged

News styling #480

merged 20 commits into from
Jul 5, 2023

Conversation

gregnewman
Copy link
Collaborator

This PR:

  • Styles the news list for desktop and mobile.
  • Styles news forms for desktop and mobile.
  • Styles news detail view for desktop and mobile.
  • Styles confirmation for deletion of news
  • Styles editing news

Additional styling for Library version alerts and avatar corner rounding.

* Adds styles for the interim news submission view
* Refactors the form input include
* Styles the news creation forms
* More work on the news list.  Linking to the filtered list from the icons next to each news item.
* Adds styles for the interim news submission view
* Refactors the form input include
* Styles the news creation forms
* More work on the news list.  Linking to the filtered list from the icons next to each news item.
…nto style-news-forms

# Conflicts:
#	static/css/styles.css
#	templates/news/create.html
#	templates/news/list.html
The original ordered list does not scale well width wise so I’ve refactored this to adjust nicely when resizing the window.
Don’t use placeholder as labels. That’s confusing.
@gregnewman gregnewman merged commit e0f1d0f into develop Jul 5, 2023
2 checks passed
@gregnewman gregnewman deleted the style-news-forms branch July 5, 2023 18:46
@gregnewman
Copy link
Collaborator Author

@nessita just to let you know, in this PR I commented out a few assertions in the view tests that were testing values of context that was either removed completely or changed outside of the views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant