Update avatars. #1317
Merged
Update avatars. #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brianjp93
commented
Oct 3, 2024
brianjp93
commented
- fixes Add names and info to avatars #1309
|
3 column breakpoint |
rbbeeston
approved these changes
Oct 3, 2024
| text-green | ||
| {% elif av_contributor_label|lower == 'contributor' %} | ||
| text-gray-400 | ||
| {% endif %} |
There was a problem hiding this comment.
@vinniefalco are there any other contributor types we need to call out beyond Maintainer, New Contributor, and Contributor?
templates/partials/avatar.html
Outdated
| <div class="w-min text-center flex flex-col justify-center items-center"> | ||
| <div | ||
| class="{{ av_size }} bg-gray-300 dark:bg-slate flex items-center justify-center relative rounded-lg" | ||
| title="{{ av_title }}{% if av_is_new %} - NEW!{% endif %}"> |
There was a problem hiding this comment.
do we still need to call out new contributors in the hover text?
There was a problem hiding this comment.
Probably not. I'll remove it
- fixes boostorg#1309
brianjp93
force-pushed
the
1309-avatar-updates
branch
from
2a64880
to
ba66f7e
Compare
|
@rbbeeston Do the contributors on the release page also need to use this "wide" avatar? It's still using the default square avatar. |
|
Yes, it should stay consistent on the release page, since it's displayed in the same way. I'll put it in a separate ticket, though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.