Create an avatar tag to be usable anywhere we need an avatar. #1298
Conversation
brianjp93
commented
Sep 27, 2024
brianjp93
commented
- fixes Create partial for avatars #1285
- Use a django tag to render an avatar component.
|
I did this using a partial + a django tag so the avatar can be created using just a django tag. I'm also open to using the partial with a surrounding |
brianjp93
force-pushed
the
1285-avatar-partial
branch
2 times, most recently
from
43ece9b
to
2ad9acd
Compare
brianjp93
force-pushed
the
1285-avatar-partial
branch
from
2ad9acd
to
8b98c9d
Compare
|
@rbbeeston Updated header avatar and avatar on /users/me/ |
brianjp93
force-pushed
the
1285-avatar-partial
branch
from
8b98c9d
to
abb2046
Compare
- fixes boostorg#1285 - Use a django tag to render an avatar component.
brianjp93
force-pushed
the
1285-avatar-partial
branch
from
abb2046
to
d4b5560
Compare
|
I don't know what a "django tag" is, but I like the sound of it |
| <div class="w-8 h-8 rounded bg-gray-300 mx-auto"></div> | ||
| {% endif %} | ||
| <div class="flex flex-col gap-y-2 w-20 items-center"> | ||
| {% avatar name=author.name image_url=author.avatar_url href=author.github_profile_url %} |
There was a problem hiding this comment.
This is a django tag? It looks just like a partial.. what am I missing?
There was a problem hiding this comment.
It's similar to a partial.
- The way that it is created is slightly different.
{% include "partials/avatar.html" with name="" image_url="" href="" %}
- Using a django tag ensures that the required fields are provided when using it. If we use the
includemethod instead, and don't include a name for example, it will still render but without a name.
I opted for the django tag as it's slightly easier to use but I'm fine with either way.
| <div class="w-8 h-8 rounded bg-silver"> | ||
| </div> | ||
| {% endif %} | ||
| {% avatar name=item.commit__author__name image_url=item.commit__author__avatar_url href=None %} |
There was a problem hiding this comment.
Why does "href" have different values here versus the previous one? Why is image_url different here from the previous one?
There was a problem hiding this comment.
Because the object is different. Each item in this queryset is actually a LibraryVersion with annotations to count commits by commit author per version.
|
This is certainly an improvement, and I think it could be better still. I would like to not have to specify name, image, and href individually. Instead I would like the avatar to be passed a single "object" with the appropriate keys. And delegate to the django code filling in that object. This is just my intuition, I could be wrong.... |
|
@vinniefalco I want the ability to specify those fields individually but I will create an avatar that is specifically for rendering from a user object, that may be what you want. |
|
This PR is fine as-is, and if you want to add rendering from a user object that is OK too and it being in a separate PR is also ok. |
brianjp93
force-pushed
the
1285-avatar-partial
branch
from
4775881
to
cffc89e
Compare
brianjp93
force-pushed
the
1285-avatar-partial
branch
from
cffc89e
to
16e9d62
Compare
