Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence compile warning on msvc #340

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

Shauren
Copy link
Contributor

@Shauren Shauren commented Sep 12, 2023

Warning

1>StartProcess.cpp
1>C:\Program Files\boost_1_83_0\boost/process/pipe.hpp(132,5): warning C4297: 'boost::process::basic_pipebuf<char,std::char_traits<char>>::~basic_pipebuf': function assumed not to throw an exception but does
1>C:\Program Files\boost_1_83_0\boost/process/pipe.hpp(132,5): message : destructor or deallocator has a (possibly implicit) non-throwing exception specification
1>C:\Program Files\boost_1_83_0\boost/process/pipe.hpp(124,6): message : while compiling class template member function 'boost::process::basic_pipebuf<char,std::char_traits<char>>::~basic_pipebuf(void)'
1>C:\Program Files\boost_1_83_0\boost/process/pipe.hpp(304,42): message : see reference to class template instantiation 'boost::process::basic_pipebuf<char,std::char_traits<char>>' being compiled
1>C:\Users\shaur\Desktop\Sources\TrinityCore\src\common\Utilities\StartProcess.cpp(85,14): message : see reference to class template instantiation 'boost::process::basic_ipstream<char,std::char_traits<char>>' being compiled

cl.exe version

Microsoft (R) C/C++ Optimizing Compiler Version 19.37.32822 for x64

@klemens-morgenstern
Copy link
Collaborator

Thanks. This has to be a weird compiler detial.

@Shauren
Copy link
Contributor Author

Shauren commented Sep 13, 2023

Weird compiler detail or not, this warning impacts my CI jobs with treat-warnings-as-errors enabled

@klemens-morgenstern klemens-morgenstern merged commit 507768e into boostorg:develop Sep 14, 2023
9 of 24 checks passed
@Shauren Shauren deleted the fix_msvc_warning branch September 14, 2023 06:26
fanquake added a commit to bitcoin-core/gui that referenced this pull request Nov 30, 2023
6d05c4f msvc: Specify `boost-date-time` package explicitly (Hennadii Stepanov)
1f97e51 msvc: Update vcpkg manifest baseline up to "2023.08.09 Release" (Hennadii Stepanov)
2d2ef2f msvc: No need to specify the default feature for `libevent` package (Hennadii Stepanov)

Pull request description:

  Last time we updated dependency packages used when compiling with MSVC in bitcoin/bitcoin#26891. Then we [switched](bitcoin/bitcoin#27335) to specifying the `builtin-baseline` in the `vcpkg.json` manifest file, which made checking out the entire vcpkg repository to a specific commit or tag unneeded.

  This PR updates the manifest baseline from [2023.01.09](https://github.com/microsoft/vcpkg/releases/tag/2023.01.09) to [2023.08.09](https://github.com/microsoft/vcpkg/releases/tag/2023.08.09):
  - berkeleydb: 4.8.30#8 --> 4.8.30#9
  - boost: 1.81.0 --> 1.82.0#2
  - sqlite3: 3.40.0#1 --> 3.42.0#1
  - zeromq: 4.3.4#6 --> 2023-06-20#1

  The most recent https://github.com/microsoft/vcpkg/releases/tag/2023.11.20 tag is still unavailable in the vcpkg installation in the current GHA Windows image (the head commit is microsoft/vcpkg@2b14b60 only).

  The other https://github.com/microsoft/vcpkg/releases/tag/2023.10.19 tag [introduces](boostorg/process@0c42a58) a warning C4297 in the Boost.Process 1.83 that is [fixed](boostorg/process#340) in the upcoming version 1.84.

ACKs for top commit:
  fanquake:
    ACK 6d05c4f

Tree-SHA512: c71c46c13ad5a6d39ae72982b7765f690e7391092e4983887a53dceeee507c8fc256e887351bbe35c051bf88d2babeb283e17a2588ee86ec9020c4ba426bfcd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants