Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions CI #179

Merged
merged 2 commits into from
May 3, 2024
Merged

Update GitHub Actions CI #179

merged 2 commits into from
May 3, 2024

Conversation

striezel
Copy link
Contributor

The following updates are performed:

Still using the outdated actions will generate several warnings in CI runs, for example in https://github.com/boostorg/nowide/actions/runs/8432630230:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The PR will get rid of those warnings, because the newer versions of those actions use Node.js 20.

@Flamefire
Copy link
Collaborator

I'm afraid the container runs will fail as node 20 isn't available in Ubuntu 16 & 18, there is a workaround in Boost.CI: https://github.com/boostorg/boost-ci/blob/ed7ead8ae9b31b7f523850b0a0debd255a62f0cf/.github/workflows/ci.yml#L145-L147

The following updates are performed:
* update actions/cache to v4
* update actions/checkout to v4
@striezel
Copy link
Contributor Author

striezel commented May 3, 2024

OK. I've added the workaround. Let's see whether this works here, too.

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (9d35cc4) to head (dd1a4f1).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #179      +/-   ##
===========================================
+ Coverage    97.72%   99.45%   +1.73%     
===========================================
  Files           34       34              
  Lines         3034     3319     +285     
===========================================
+ Hits          2965     3301     +336     
+ Misses          69       18      -51     

see 31 files with indirect coverage changes

@Flamefire
Copy link
Collaborator

Ok, makes the file and output a bit more ugly but hopefully can be removed at some point. Thanks!

@Flamefire Flamefire merged commit 5acfcda into boostorg:develop May 3, 2024
78 checks passed
@striezel striezel deleted the actions-update branch May 5, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants