Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning '_CRT_SECURE_NO_WARNINGS': macro redefinition #177

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

Jackarain
Copy link
Contributor

No description provided.

@Flamefire
Copy link
Collaborator

Thanks for the PR. I'm wondering in which situation you encounter this issue. Those files changed are internal source files and the build scripts don't define those defines. So how do you run into the warning?

@Jackarain
Copy link
Contributor Author

Jackarain commented Dec 25, 2023

Thanks for reviewing this.
The issue stems from the add_definitions(-D_CRT_SECURE_NO_WARNINGS) used in main projects, causing a macro redefinition warning with your files. My PR aims to resolve this for smoother integration.

https://github.com/Jackarain/proxy/actions/runs/7319843765/job/19938178701#step:3:1403

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9cea73) 99.47% compared to head (3c4e045) 99.47%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #177   +/-   ##
========================================
  Coverage    99.47%   99.47%           
========================================
  Files           34       34           
  Lines         3447     3447           
========================================
  Hits          3429     3429           
  Misses          18       18           
Files Coverage Δ
src/cstdio.cpp 100.00% <ø> (ø)
src/cstdlib.cpp 91.66% <ø> (ø)
test/test_system.cpp 100.00% <ø> (ø)

@Flamefire Flamefire merged commit e040930 into boostorg:develop Dec 26, 2023
78 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 26, 2023
Fix warning '_CRT_SECURE_NO_WARNINGS': macro redefinition'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants