Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removed tgamma error handling path #1195

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Fix removed tgamma error handling path #1195

merged 2 commits into from
Sep 9, 2024

Conversation

mborland
Copy link
Member

@mborland mborland commented Sep 9, 2024

Closes: #1194

Confirmed on device: cppalliance/cuda-math#24

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.79%. Comparing base (cb06899) to head (9d13307).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
include/boost/math/special_functions/gamma.hpp 87.50% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1195   +/-   ##
========================================
  Coverage    93.78%   93.79%           
========================================
  Files          655      656    +1     
  Lines        53783    53804   +21     
========================================
+ Hits         50440    50464   +24     
+ Misses        3343     3340    -3     
Files with missing lines Coverage Δ
test/git_issue_1194.cpp 100.00% <100.00%> (ø)
include/boost/math/special_functions/gamma.hpp 92.14% <87.50%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb06899...9d13307. Read the comment docs.

@mborland mborland merged commit 84a7bdd into develop Sep 9, 2024
79 checks passed
@mborland mborland deleted the 1194 branch September 9, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lost error handling in tgamma
1 participant