Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU Batch 9 #1192

Merged
merged 1 commit into from
Sep 6, 2024
Merged

GPU Batch 9 #1192

merged 1 commit into from
Sep 6, 2024

Conversation

mborland
Copy link
Member

@mborland mborland commented Sep 4, 2024

In this PR we continue to build out support for the distributions now that we have complete implementations of the beta and gamma function families. Adds support for: fisher f dist, gamma dist, geometric dist, inverse chi squared dist, and inverse gamma dist.

Minor change to the testing is to reduce the number of threads per block from 512 to 256. The CI system started to error on lack of resources.

Completed CI runs can be found here: cppalliance/cuda-math#20

Add SYCL testing of fisher f dist

Add CUDA fisher f dist testing

Add NVRTC fisher f dist testing

Add GPU support to gamma dist

Add SYCL testing of gamma dist

Add CUDA gamma dist testing

Add NVRTC gamma dist testing

Reduce number of threads per block since it can crash CI

Add GPU support to the geometric dist

Add SYCL testing of geometric dist

Add cuda::std::tie

Add GPU support to inv_discrete_quantile

Add CUDA testing of geometric dist

Add NVRTC testing of geometric dist

Add SYCL testing of inverse_chi_squared dist

Adjust tol

Add NVRTC inverse chi squared dist testing

Add CUDA inverse chi squared dist testing

Add GPU support to inverse gamma dist

Add SYCL testing to inverse gamma dist

Add NVRTC testing of inverse gamma dist

Add CUDA testing of inverse gamma dist
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 98.31461% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.09%. Comparing base (ab57b20) to head (d01893d).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
include/boost/math/distributions/geometric.hpp 94.87% 2 Missing ⚠️
include/boost/math/distributions/gamma.hpp 97.14% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1192   +/-   ##
========================================
  Coverage    94.09%   94.09%           
========================================
  Files          780      780           
  Lines        65851    65907   +56     
========================================
+ Hits         61960    62016   +56     
  Misses        3891     3891           
Files with missing lines Coverage Δ
...ath/distributions/detail/inv_discrete_quantile.hpp 88.50% <100.00%> (ø)
include/boost/math/distributions/fisher_f.hpp 84.61% <100.00%> (+0.98%) ⬆️
...e/boost/math/distributions/inverse_chi_squared.hpp 91.48% <100.00%> (+0.72%) ⬆️
include/boost/math/distributions/inverse_gamma.hpp 80.30% <100.00%> (+1.27%) ⬆️
test/test_fisher_f.cpp 100.00% <ø> (ø)
test/test_gamma_dist.cpp 100.00% <ø> (ø)
test/test_geometric.cpp 100.00% <ø> (ø)
test/test_inverse_chi_squared_distribution.cpp 100.00% <ø> (ø)
test/test_inverse_gamma_distribution.cpp 100.00% <ø> (ø)
include/boost/math/distributions/gamma.hpp 83.33% <97.14%> (+1.31%) ⬆️
... and 1 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab57b20...d01893d. Read the comment docs.

@mborland mborland merged commit 54c229b into develop Sep 6, 2024
79 checks passed
@mborland mborland deleted the gpu_batch_9 branch September 6, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant