Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove link against boost regex library, as normally it is header only when using C++ >= 11. #352

Conversation

Romain-Geissler-1A
Copy link
Contributor

It seems you recently dropped all support for gcc 4.x and C++ < 11 in general, so normally with the compilers you still support the Boost regex library shall be header only. Thus avoid linking against it explicitly.

I didn't test this locally, so let's wait the result of the CI.

@Romain-Geissler-1A
Copy link
Contributor Author

It looks like this breaks all clang < 4.x tests. How ok is it to remove clang 3.6 to 3.9 from the supported compilers ? Clang 4.0.0 debuted in march 2017, so 6 years ago. The oldest gcc release you still support, gcc 5, debuted in April 2015, so 8 years ago.

@jeremy-murphy
Copy link
Contributor

Thanks for updating this.

I'd like to remove more old compilers from the CI, but I'll just check my notes to see if anyone was actively using them.

@jeremy-murphy jeremy-murphy self-assigned this Dec 3, 2023
@jeremy-murphy
Copy link
Contributor

I just removed Clang 3.x from the Drone config, so please rebase on to the latest develop.

@Romain-Geissler-1A
Copy link
Contributor Author

Ok I just did, let's see how the CI reacts now ;)

@jeremy-murphy
Copy link
Contributor

Thanks, that's great. The change looks good to me, but I'm not an expert on the b2 build configuration, so I might ask someone else to quickly review it too.

@pdimov
Copy link
Member

pdimov commented Dec 7, 2023

It doesn't matter whether a library is header-only or not, you still have to link to it, or it won't work.

If this doesn't break CI, then CI doesn't test CMake.

@Romain-Geissler-1A
Copy link
Contributor Author

Ok, I have reverted the CMakeLists.txt changes.

@Romain-Geissler-1A
Copy link
Contributor Author

Ping

@jeremy-murphy
Copy link
Contributor

Ping

Sorry, been on holidays!

@jeremy-murphy jeremy-murphy merged commit a7c3845 into boostorg:develop Jan 1, 2024
8 checks passed
@jeremy-murphy
Copy link
Contributor

Thanks for improving that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants