Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the output #162

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Changed the output #162

wants to merge 1 commit into from

Conversation

sreejithsankar55
Copy link

Fix: #161

Tested and fixed the output in the file subgraph.cpp and subgraph.expected

@sreejithsankar55 sreejithsankar55 changed the title Second Changed the output Feb 12, 2019
@anadon
Copy link
Contributor

anadon commented Apr 5, 2019

Could you be more literal in what is incorrect? It looks like you're changing documentation and no code.

@sreejithsankar55
Copy link
Author

Could you be more literal in what is incorrect? It looks like you're changing documentation and no code.
@anadon The output in the documentation of subgraph.expected and the commented part of subgraph.cpp is wrong when I tested the code locally, it produces a different output rather than the expected. Hence, I changed it to exactly what the code produces as the output.

@anadon
Copy link
Contributor

anadon commented Apr 6, 2019

I have serious misgivings about correctness here. Those examples are old and when they were originally made they were very likely validated. It it possible internal behavior has changes or there is a bug, but you're going to need to provide a test case.

How are you generating your results? Please include your code.

@jeremy-murphy jeremy-murphy self-assigned this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expected outputs of subgraph is incorrect
3 participants