Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move base_channel_type_impl to detail namespace #681

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

marco-langer
Copy link
Contributor

Description

This PR moves base_channel_type_impl to detail namespace.

Tasklist

  • Ensure all CI builds pass
  • Review and approve

@marco-langer marco-langer changed the title refactor: Move base_channel_type_impl to detail namespace WIP: refactor: Move base_channel_type_impl to detail namespace Jun 4, 2022
@mloskot
Copy link
Member

mloskot commented Jun 26, 2022

@marco-langer Why closing?

@marco-langer
Copy link
Contributor Author

@mloskot I wanted to discuss this PR with you before working on it again, but I thought currently the Boost 1.80 PRs are more important.

I think those structs belong to the detail namespace, but they are currently not. However, just moving stuff around would violate boosts deprecation policy, right?

So, some of my solutions:

  • Keep the PR as is and have a possible breaking change if someone relied on those structs (I doubt it, but I am not sure).
  • Create new detail structs, redirect the library calls to the detail structs and deprecate the old structs in the gil namespace.
  • Leave everything as it is currently implemented and don't wake up sleeping dogs.

@mloskot
Copy link
Member

mloskot commented Jun 26, 2022

OK. You can always turn PR to Draft.

Boost 1.80 PRs are more important.

Yes, indeed.

However, just moving stuff around would violate boosts deprecation policy, right?

Generally speaking, yes.
However, I doubt any user directly refers to base_channel_type_impl type. We can not exclude such possibility though.

Let's postpone it.

@marco-langer marco-langer reopened this Jun 26, 2022
@marco-langer marco-langer marked this pull request as draft June 26, 2022 10:22
@marco-langer marco-langer changed the title WIP: refactor: Move base_channel_type_impl to detail namespace refactor: Move base_channel_type_impl to detail namespace Jun 26, 2022
@mloskot mloskot added this to the Boost 1.81+ milestone Jul 7, 2022
@mloskot mloskot modified the milestones: Boost 1.82, Boost 1.83+ Mar 31, 2023
@mloskot mloskot modified the milestones: Boost 1.86, 1.87.0 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants