-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add partial release notes for Boost 1.80 #670
docs: Add partial release notes for Boost 1.80 #670
Conversation
Includes changes up to commit 25 from the table shown in <boostorg#667>.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually don't include changes related to CI and internal configurations that end-user is not really interested in.
We also don't take notes on changes to build configurations, unless a breaking change or new feature end-users of the library can utilise. As I mentioned some time ago, our release notes != our change log.
Since we have no notes for release managers, there was no way for you to know it.
In fact, I have made the mistake myself merging #665 - this note should be removed.
I highly appreciate your help @striezel
Thanks for the feedback. I've removed the CI stuff from the release notes.
Should this be a separate PR or should it be handled here, too? In the latter case, there might probably be a merge conflict when merging from |
1a5c1c6
to
062c373
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks for the merge. Just a few minutes more and you would have been able to merge the whole release notes at once. :D But now it's another PR: #672. I probably should have communicated that I was working on the rest of those release notes, too.
Alright. |
No problem, baby steps 😊 |
No, I do not have that option here, but I can change the PR's title. |
I've just learned "Convert to draft" is available only to those with write access to a repo: https://github.blog/changelog/2020-04-08-convert-pull-request-to-draft/ - that is about changing stage of existing PR. But, AFAIU, everyone should be able to create a draft pull request: https://github.blog/2019-02-14-introducing-draft-pull-requests/ Anyway, `WIP:'-ing a PR or creating a draft will work for us. |
Description
Includes changes up to commit 25 (hash 434e78f76) from the table shown in #667.
References
See #667.
Tasklist