Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add partial release notes for Boost 1.80 #670

Merged
merged 2 commits into from
May 13, 2022

Conversation

striezel
Copy link
Contributor

@striezel striezel commented May 12, 2022

Description

Includes changes up to commit 25 (hash 434e78f76) from the table shown in #667.

References

See #667.

Tasklist

  • Review and approve

Includes changes up to commit 25 from the table shown in
<boostorg#667>.
@mloskot mloskot changed the title add partial release notes for Boost 1.80 docs: Add partial release notes for Boost 1.80 May 12, 2022
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually don't include changes related to CI and internal configurations that end-user is not really interested in.
We also don't take notes on changes to build configurations, unless a breaking change or new feature end-users of the library can utilise. As I mentioned some time ago, our release notes != our change log.
Since we have no notes for release managers, there was no way for you to know it.

In fact, I have made the mistake myself merging #665 - this note should be removed.

I highly appreciate your help @striezel

@mloskot mloskot added this to the Boost 1.80 milestone May 12, 2022
@mloskot mloskot mentioned this pull request May 12, 2022
1 task
@striezel
Copy link
Contributor Author

Thanks for the feedback.

I've removed the CI stuff from the release notes.

In fact, I have made the mistake myself merging #665 - this note should be removed.

Should this be a separate PR or should it be handled here, too? In the latter case, there might probably be a merge conflict when merging from develop to master.

@striezel striezel requested a review from mloskot May 13, 2022 00:09
@mloskot
Copy link
Member

mloskot commented May 13, 2022

@striezel I've just reverted the RELEASES.md change in 616cf28

Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mloskot mloskot merged commit ec9f0b0 into boostorg:develop May 13, 2022
@striezel
Copy link
Contributor Author

Thanks for the merge.

Just a few minutes more and you would have been able to merge the whole release notes at once. :D But now it's another PR: #672. I probably should have communicated that I was working on the rest of those release notes, too.

I've just reverted the RELEASES.md change in 616cf28

Alright.

@mloskot
Copy link
Member

mloskot commented May 13, 2022

No problem, baby steps 😊
GitHub allows to mark PR as draft, but I'm not sure if you can access that option?
If not, then simply prefix the subject with WIP: until it's ready to be reviewed and merged.

@striezel
Copy link
Contributor Author

GitHub allows to mark PR as draft, but I'm bot sure if you can access that option?

No, I do not have that option here, but I can change the PR's title.

@mloskot
Copy link
Member

mloskot commented May 14, 2022

I've just learned "Convert to draft" is available only to those with write access to a repo: https://github.blog/changelog/2020-04-08-convert-pull-request-to-draft/ - that is about changing stage of existing PR.

But, AFAIU, everyone should be able to create a draft pull request: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Anyway, `WIP:'-ing a PR or creating a draft will work for us.

@mloskot mloskot mentioned this pull request Jul 5, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants